Arch Linux

Therk

Member

Registered: 2023-02-02

Posts: 6

PKGBUILD review: madbfs

For the first time in a while, I found some software I wanted that wasn't on the AUR, so I decided to write a PKGBUILD for it! I've already read the AUR submission guidelines at least twice, and as is suggested over there, I'm posting it here to get some feedback just in case it's really bad.

The package installs madbfs and a tiny wrapper script. The wrapper only makes it so madbfs is always launched with an option that circumvents a cache issue the software is currently experiencing.

# Maintainer: Muhammad Rizal Nurromdhoni <mrizaln2000 at gmail dot com>
# AUR packager: Élie Leblanc <leblancelie.moi at gmail dot com>
pkgname=madbfs-bin
pkgver=0.11.0
pkgrel=1
pkgdesc="Mount Android phones on Linux with adb (userspace filesystem for Android via adb using FUSE)"
arch=(x86_64)
url="https://github.com/mrizaln/madbfs"
license=('MIT')
depends=(android-tools)
makedepends=(chrpath)
provides=(madbfs)
source=("$url/releases/download/v$pkgver/madbfs.tar.gz"
"https://raw.githubusercontent.com/mrizaln/madbfs/refs/heads/main/LICENSE"
"https://raw.githubusercontent.com/mrizaln/madbfs/refs/heads/main/README.md")
sha256sums=('edbb40dd0c4f16edc26fe1141e44a3233238730937f16fb14bb1d7b4cbf4ae6f'
'd68068da79f0c8225b909483230ec9b5bf79b50cef70fc5720509d60ec9d3cc1'    
'8c415279df95517f4660721d7a667bda7fc6e8823c67792f34f6edc00092224a')

package(){
	chrpath -d "${srcdir}/madbfs/madbfs"
	echo -e "#!/bin/sh\n/usr/bin/madbfs-bin --no-cache \$@" > "${srcdir}/madbfs/madbfs-wrapper-script"
	install -Dm755 "${srcdir}/madbfs/madbfs" "${pkgdir}/usr/bin/madbfs-bin"
	install -Dm755 "${srcdir}/madbfs/madbfs-wrapper-script" "${pkgdir}/usr/bin/madbfs"
	install -Dm644 "${srcdir}/LICENSE" "${pkgdir}/usr/share/licenses/madbfs-bin/MIT.txt"
	install -Dm644 "${srcdir}/README.md" "${pkgdir}/usr/share/doc/madbfs/README.md"
}

How'd I do?

Also, AUR account registration seems to be broken currently? I can't access the page u

Last edited by Therk (Yesterday 17:49:33)

yochananmarqos

Member

Registered: 2020-02-05

Posts: 222

Re: PKGBUILD review: madbfs

It should both provide and conflict with madbfs. Looks like there may be more dependencies required like libfuse2 or libfuse3.

AUR registrations may be disabled at the moment due to the flood of malicious AUR package updates in the last hour or two.

Last edited by yochananmarqos (Yesterday 16:18:27)

Therk

Member

Registered: 2023-02-02

Posts: 6

Re: PKGBUILD review: madbfs

The libraries are statically linked in the binary, so libfuse is a dependency, but only if you build from source. I'd like to get a version of the package that builds from source, but for that I'd need to package some C++ dependencies that aren't in the AUR at the moment.

A flood of malicious packages seems like a good reason to temporarily block registration lol.